PR to review

[faddat]

The community may wish to review the following pull requests:

• Lint again by faddat · Pull Request #178 · classic-terra/core · GitHub

• Cleanup to make for easier triage by faddat · Pull Request #160 · classic-terra/core · GitHub

It is always best to use software that hasn’t been deprecated. Tests make software safer.

[faddat]

My word

For some reason dude really really wants to use a deprecated version of the go programming language.

The guidance from the cosmos SDK maintenance team is to move to 1.19 or 1.20 at the next state breaking change.

That is simply their guidance.

[faddat]

findings

• V0.45.13 proposal #176 should use tendermint v0.34.26 with terra patches applied to avoid a cpu griefing attack vector ← documented at GitHub - informalsystems/tendermint: A temporary fork of the original Tendermint Core repository (please use CometBFT instead)
• lunc should not use a deprecated go runtime as outlined in the guidelines for using the cosmos-sdk ← fixed
• V0.45.13 proposal #176 should use cosmos-sdk v0.45.14+ ← should be addressed in V0.45.13 proposal #176 by updating the cosmos-sdk fork
• code should be formatted in a standard manner ← fixed
• numerous needless replace statements in go.mod ← fixed
• go.mod should be annotated as in cleanup go.mod #179 for clarity ← should be merged to V0.45.13 proposal #176
• unused code should be removed ← fixed
• when writing tests, errors should be checked ← fixed
• go 1.18 is deprecated and lunc should use 1.19 or 1.20 ← fixed
• go runtimes should never be mixed in production networks ← fixed, but should ensure that a standardized build guide is distributed to validators

I have downgraded go at the explicit request of Tobias Andersen.

[arunadaybasu]

I am just inquisitive. You are obviously not part of the L1 team. Or are you?

Also, why did you downgrade the version of go? This could create security issues, which could lead to exploits of the system. What’s the issue currently with upgrading go? I can see that Z said not to do it, but why aren’t they fixing the breaking changes?

[JCP.ESQ]

What would be the best way to support your work on Terra Classic?

[arunadaybasu]

@faddat

findings

I didn’t comment on this before but I can see what you have done here.

We needed a check like this for the chain. In fact, you should have been on the L1 team. For whatever reason, you are an independent developer.

I know you from TR’s repo cause obviously you are the contributor with the highest number of commits. You are also a contributor on Cosmos.

I dunno who you are, but I thank you for your work till now and I hope that you continue to develop for LUNC.

[RabbiJebediah]

You do all this for free.

Meanwhile that clown Tobias is getting $13,000/month to write a wiki.

This community doesn’t know its face from its asshole.